Merge pull request #13 from j0k3r/monolog

Use Monolog instead of custom solution

.scrutinizer.yml

@@ -1,3 +1,2 @@
 tools:
-    external_code_coverage:
-        timeout: 600
+    external_code_coverage: false

.travis.yml

@@ -6,29 +6,37 @@ php:
     - 5.4
     - 5.5
     - 5.6
-    - nightly
+    - 7.0
     - hhvm
 
-# run build against nightly but allow them to fail
 matrix:
     fast_finish: true
     allow_failures:
-        - php: nightly
         - php: hhvm
 
 # faster builds on new travis setup not using sudo
 sudo: false
 
+# cache vendor dirs
+cache:
+    directories:
+        - vendor
+        - $HOME/.composer/cache
+
 install:
     - composer self-update
 
 before_script:
+    - if [ -n "$GH_TOKEN" ]; then composer config github-oauth.github.com ${GH_TOKEN}; fi;
+    # disable TLS for composer because openssl is disabled for PHP 5.3.3 on travis
+    # see: https://blog.travis-ci.com/upcoming_ubuntu_11_10_migration/
+    - if [[ $TRAVIS_PHP_VERSION = 5.3.3 ]]; then composer config -g -- disable-tls true; fi;
+    - if [[ $TRAVIS_PHP_VERSION = 5.3.3 ]]; then composer config -g -- secure-http false; fi;
     - composer install --prefer-dist --no-interaction
 
 script:
-    - phpunit --coverage-clover=coverage.clover
+    - mkdir -p build/logs
+    - phpunit -v --coverage-clover build/logs/clover.xml
 
 after_script:
-    - |
-        wget https://scrutinizer-ci.com/ocular.phar
-        php ocular.phar code-coverage:upload --format=php-clover coverage.clover
+    - php vendor/bin/coveralls -v

README.md

@@ -1,7 +1,7 @@
 # Readability
 
 [![Build Status](https://travis-ci.org/j0k3r/php-readability.svg?branch=master)](https://travis-ci.org/j0k3r/php-readability)
-[![Code Coverage](https://scrutinizer-ci.com/g/j0k3r/php-readability/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/j0k3r/php-readability/?branch=master)
+[![Coverage Status](https://coveralls.io/repos/j0k3r/php-readability/badge.svg?branch=master&service=github)](https://coveralls.io/github/j0k3r/php-readability/?branch=master)
 
 This is an extract of the Readability class from this [full-text-rss](https://github.com/Dither/full-text-rss) fork. It can be defined as a better version of the original [php-readability](https://bitbucket.org/fivefilters/php-readability/overview).
 
@@ -45,3 +45,20 @@ if ($result) {
     echo 'Looks like we couldn\'t find the content. :(';
 }
 ```
+
+If you want to debug it, or check what's going on, you can inject a logger (which must follow `Psr\Log\LoggerInterface`, Monolog for example):
+
+```php
+use Readability\Readability;
+use Monolog\Logger;
+use Monolog\Handler\StreamHandler;
+
+$url = 'http://www.medialens.org/index.php/alerts/alert-archive/alerts-2013/729-thatcher.html';
+$html = file_get_contents($url);
+
+$logger = new Logger('readability');
+$logger->pushHandler(new StreamHandler('path/to/your.log', Logger::DEBUG));
+
+$readability = new Readability($html, $url);
+$readability->setLogger($logger);
+```

composer.json

@@ -24,7 +24,11 @@
         "role": "Developer (original JS version)"
     }],
     "require": {
-        "php": ">=5.3.3"
+        "php": ">=5.3.3",
+        "monolog/monolog": "^1.13.1"
+    },
+    "require-dev": {
+        "satooshi/php-coveralls": "~0.6"
     },
     "autoload": {
         "psr-4": { "Readability\\": "src/" }

phpunit.xml.dist

@@ -26,7 +26,7 @@
         </whitelist>
     </filter>
 
-    <logging>
+    <!-- <logging>
         <log type="coverage-html" target="coverage" title="Readability" charset="UTF-8" yui="true" highlight="true" lowUpperBound="35" highLowerBound="70"/>
-    </logging>
+    </logging> -->
 </phpunit>

src/JSLikeHTMLElement.php

@@ -56,7 +56,8 @@ class JSLikeHTMLElement extends \DOMElement
                 $f = $this->ownerDocument->createDocumentFragment();
 
                 // appendXML() expects well-formed markup (XHTML)
-                $result = @$f->appendXML($value); // @ to suppress PHP warnings
+                // @ to suppress PHP warnings
+                $result = @$f->appendXML($value);
                 if ($result) {
                     if ($f->hasChildNodes()) {
                         $this->appendChild($f);
@@ -75,6 +76,7 @@ class JSLikeHTMLElement extends \DOMElement
 
                     if ($result) {
                         $import = $f->getElementsByTagName('htmlfragment')->item(0);
+
                         foreach ($import->childNodes as $child) {
                             $importedNode = $this->ownerDocument->importNode($child, true);
                             $this->appendChild($importedNode);
@@ -102,6 +104,7 @@ class JSLikeHTMLElement extends \DOMElement
     {
         if ($name == 'innerHTML') {
             $inner = '';
+
             foreach ($this->childNodes as $child) {
                 $inner .= $this->ownerDocument->saveXML($child);
             }

tests/ReadabilityTest.php

@@ -3,75 +3,66 @@
 namespace Tests\Readability;
 
 use Readability\Readability;
-
-class ReadabilityTested extends Readability
-{
-    public function getDebugText()
-    {
-        return $this->debugText;
-    }
-
-    public function getDomainRegexp()
-    {
-        return $this->domainRegExp;
-    }
-}
+use Monolog\Logger;
+use Monolog\Handler\TestHandler;
 
 class ReadabilityTest extends \PHPUnit_Framework_TestCase
 {
-    /**
-     * @requires extension tidy
-     */
-    public function testConstructDefault()
-    {
-        $readability = new ReadabilityTested('');
+    public $logHandler;
+    public $logger;
 
-        $this->assertNull($readability->url);
-        $this->assertContains('Parsing URL', $readability->getDebugText());
-        $this->assertContains('Tidying document', $readability->getDebugText());
-        $this->assertNull($readability->getDomainRegexp());
-        $this->assertInstanceOf('DomDocument', $readability->dom);
+    private function getReadability($html, $url = null, $parser = 'libxml', $useTidy = true)
+    {
+        $readability = new Readability($html, $url, $parser, $useTidy);
+
+        $this->logHandler = new TestHandler();
+        $this->logger = new Logger('test', array($this->logHandler));
+        $readability->setLogger($this->logger);
+
+        return $readability;
     }
 
-    /**
-     * @requires extension tidy
-     */
     public function testConstructSimple()
     {
-        $readability = new ReadabilityTested('<html/>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<html/>', 'http://0.0.0.0');
+        $readability->init();
 
         $this->assertEquals('http://0.0.0.0', $readability->url);
-        $this->assertContains('Parsing URL', $readability->getDebugText());
-        $this->assertContains('Tidying document', $readability->getDebugText());
-        $this->assertEquals('/0\.0\.0\.0/', $readability->getDomainRegexp());
-        $this->assertInstanceOf('DomDocument', $readability->dom);
+        $this->assertEquals('<html/>', $readability->original_html);
+        $this->assertTrue($readability->tidied);
+
+        $this->assertTrue($this->logHandler->hasDebugThatContains('Parsing URL: http://0.0.0.0'));
+        $this->assertTrue($this->logHandler->hasDebugThatContains('Tidying document'));
+        $this->assertTrue($this->logHandler->hasDebugThatContains('Light clean enabled.'));
     }
 
     public function testConstructDefaultWithoutTidy()
     {
-        $readability = new ReadabilityTested('', null, 'libxml', false);
+        $readability = $this->getReadability('', null, 'libxml', false);
+        $readability->init();
 
         $this->assertNull($readability->url);
-        $this->assertContains('Parsing URL', $readability->getDebugText());
-        $this->assertNotContains('Tidying document', $readability->getDebugText());
-        $this->assertNull($readability->getDomainRegexp());
-        $this->assertInstanceOf('DomDocument', $readability->dom);
+        $this->assertEquals('', $readability->original_html);
+        $this->assertFalse($readability->tidied);
+
+        $this->assertTrue($this->logHandler->hasDebugThatContains('Parsing URL: '));
+        $this->assertFalse($this->logHandler->hasDebugThatContains('Tidying document'));
+        $this->assertTrue($this->logHandler->hasDebugThatContains('Light clean enabled.'));
     }
 
     public function testConstructSimpleWithoutTidy()
     {
-        $readability = new ReadabilityTested('<html/>', 'http://0.0.0.0', 'libxml', false);
+        $readability = $this->getReadability('<html/>', 'http://0.0.0.0', 'libxml', false);
+        $readability->init();
 
         $this->assertEquals('http://0.0.0.0', $readability->url);
-        $this->assertContains('Parsing URL', $readability->getDebugText());
-        $this->assertNotContains('Tidying document', $readability->getDebugText());
-        $this->assertEquals('/0\.0\.0\.0/', $readability->getDomainRegexp());
-        $this->assertInstanceOf('DomDocument', $readability->dom);
+        $this->assertEquals('<html/>', $readability->original_html);
+        $this->assertFalse($readability->tidied);
     }
 
     public function testInitNoContent()
     {
-        $readability = new ReadabilityTested('<html/>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<html/>', 'http://0.0.0.0');
         $res = $readability->init();
 
         $this->assertFalse($res);
@@ -83,7 +74,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testInitP()
     {
-        $readability = new ReadabilityTested(str_repeat('<p>This is the awesome content :)</p>', 7), 'http://0.0.0.0');
+        $readability = $this->getReadability(str_repeat('<p>This is the awesome content :)</p>', 7), 'http://0.0.0.0');
         $res = $readability->init();
 
         $this->assertTrue($res);
@@ -96,7 +87,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testInitDivP()
     {
-        $readability = new ReadabilityTested('<div>'.str_repeat('<p>This is the awesome content :)</p>', 7).'</div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div>'.str_repeat('<p>This is the awesome content :)</p>', 7).'</div>', 'http://0.0.0.0');
         $res = $readability->init();
 
         $this->assertTrue($res);
@@ -109,7 +100,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testInitDiv()
     {
-        $readability = new ReadabilityTested('<div>'.str_repeat('This is the awesome content :)', 7).'</div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div>'.str_repeat('This is the awesome content :)', 7).'</div>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
@@ -123,7 +114,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithFootnotes()
     {
-        $readability = new ReadabilityTested('<div>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'</div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'</div>', 'http://0.0.0.0');
         $readability->debug = true;
         $readability->convertLinksToFootnotes = true;
         $res = $readability->init();
@@ -140,7 +131,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testStandardClean()
     {
-        $readability = new ReadabilityTested('<div><h2>Title</h2>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<a href="#nofollow" rel="nofollow">will NOT be removed</a></div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div><h2>Title</h2>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<a href="#nofollow" rel="nofollow">will NOT be removed</a></div>', 'http://0.0.0.0');
         $readability->debug = true;
         $readability->lightClean = false;
         $res = $readability->init();
@@ -157,7 +148,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithIframe()
     {
-        $readability = new ReadabilityTested('<div><h2>Title</h2>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<p>This is an awesome text with some links, here there are <iframe src="http://youtube.com/test" href="#nofollow" rel="nofollow"></iframe><iframe>http://soundcloud.com/test</iframe></p></div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div><h2>Title</h2>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<p>This is an awesome text with some links, here there are <iframe src="http://youtube.com/test" href="#nofollow" rel="nofollow"></iframe><iframe>http://soundcloud.com/test</iframe></p></div>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
@@ -172,7 +163,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithArticle()
     {
-        $readability = new ReadabilityTested('<article><p>'.str_repeat('This is an awesome text with some links, here there are: the awesome', 20).'</p><p>This is an awesome text with some links, here there are <iframe src="http://youtube.com/test" href="#nofollow" rel="nofollow"></iframe></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<article><p>'.str_repeat('This is an awesome text with some links, here there are: the awesome', 20).'</p><p>This is an awesome text with some links, here there are <iframe src="http://youtube.com/test" href="#nofollow" rel="nofollow"></iframe></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
@@ -187,7 +178,22 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithAside()
     {
-        $readability = new ReadabilityTested('<article>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<footer><aside>'.str_repeat('<p>This is an awesome text with some links, here there are</p>', 8).'</aside></footer></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<article>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<footer><aside>'.str_repeat('<p>This is an awesome text with some links, here there are</p>', 8).'</aside></footer></article>', 'http://0.0.0.0');
+        $readability->debug = true;
+        $res = $readability->init();
+
+        $this->assertTrue($res);
+        $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
+        $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
+        $this->assertEmpty($readability->getTitle()->innerHTML);
+        $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
+        $this->assertNotContains('<aside>', $readability->getContent()->innerHTML);
+        $this->assertContains('<footer readability="4"/>', $readability->getContent()->innerHTML);
+    }
+
+    public function testWithClasses()
+    {
+        $readability = $this->getReadability('<article>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<div style="display:none">'.str_repeat('<p class="clock">This text should be removed</p>', 10).'</div></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
@@ -197,14 +203,14 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
         $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEmpty($readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
-        $this->assertNotContains('<aside>', $readability->getContent()->innerHTML);
-        $this->assertContains('<footer/>', $readability->getContent()->innerHTML);
+        $this->assertNotContains('This text should be removed', $readability->getContent()->innerHTML);
     }
 
-    public function testWithClasses()
+    public function testWithClassesWithoutLightClean()
     {
-        $readability = new ReadabilityTested('<article>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<div style="display:none">'.str_repeat('<p class="clock">This text should be removed</p>', 10).'</div></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<article>'.str_repeat('<p>This is an awesome text with some links, here there are: <a href="http://0.0.0.0/test.html">the awesome</a></p>', 7).'<div style="display:none">'.str_repeat('<p class="clock">This text should be removed</p>', 10).'</div></article>', 'http://0.0.0.0');
         $readability->debug = true;
+        $readability->lightClean = false;
         $res = $readability->init();
 
         $this->assertTrue($res);
@@ -218,28 +224,26 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithTd()
     {
-        $readability = new ReadabilityTested('<table><tr>'.str_repeat('<td><p>This is an awesome text with some links, here there are the awesome</td>', 7).'</tr></table>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<table><tr>'.str_repeat('<td><p>This is an awesome text with some links, here there are the awesome</td>', 7).'</tr></table>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="tr"', $readability->getContent()->innerHTML);
         $this->assertEmpty($readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
     }
 
     public function testWithSameClasses()
     {
-        $readability = new ReadabilityTested('<article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<div class="awesomecontent">This text is also an awesome text and you should know that !</div></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<div class="awesomecontent">This text is also an awesome text and you should know that !</div></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEmpty($readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -247,14 +251,13 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testWithScript()
     {
-        $readability = new ReadabilityTested('<article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p><script>This text is also an awesome text and you should know that !</script></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p><script>This text is also an awesome text and you should know that !</script></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEmpty($readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertNotContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -262,14 +265,13 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testTitle()
     {
-        $readability = new ReadabilityTested('<title>this is my title</title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<title>this is my title</title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEquals('this is my title', $readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertNotContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -277,14 +279,13 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testTitleWithDash()
     {
-        $readability = new ReadabilityTested('<title> title2 - title3 </title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<title> title2 - title3 </title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEquals('title2 - title3', $readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertNotContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -292,14 +293,13 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testTitleWithDoubleDot()
     {
-        $readability = new ReadabilityTested('<title> title2 : title3 </title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<title> title2 : title3 </title><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEquals('title2 : title3', $readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertNotContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -307,14 +307,13 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     public function testTitleTooShortUseH1()
     {
-        $readability = new ReadabilityTested('<title>too short</title><h1>this is my h1 title !</h1><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<title>too short</title><h1>this is my h1 title !</h1><article class="awesomecontent">'.str_repeat('<p>This is an awesome text with some links, here there are the awesome</p>', 7).'<p></p></article>', 'http://0.0.0.0');
         $readability->debug = true;
         $res = $readability->init();
 
         $this->assertTrue($res);
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
         $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
-        $this->assertContains('alt="article"', $readability->getContent()->innerHTML);
         $this->assertEquals('this is my h1 title !', $readability->getTitle()->innerHTML);
         $this->assertContains('This is an awesome text with some links, here there are', $readability->getContent()->innerHTML);
         $this->assertNotContains('This text is also an awesome text and you should know that', $readability->getContent()->innerHTML);
@@ -322,13 +321,9 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
 
     // public function testConstructParser()
     // {
-    //     $readability = new ReadabilityTested('<html/>', 'http://0.0.0.0', 'html5lib');
+    //     $readability = $this->getReadability('<html/>', 'http://0.0.0.0', 'html5lib');
 
     //     $this->assertEquals('http://0.0.0.0', $readability->url);
-    //     $this->assertContains('Parsing URL', $readability->getDebugText());
-    //     $this->assertContains('Tidying document', $readability->getDebugText());
-    //     $this->assertEquals('/0\.0\.0\.0/', $readability->getDomainRegexp());
-    //     $this->assertInstanceOf('DomDocument', $readability->dom);
     // }
 
     // dummy function to be used to the next test
@@ -368,7 +363,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
             </body>
             </html>';
 
-        $readability = new ReadabilityTested($data, 'http://iosgames.ru/?p=22030');
+        $readability = $this->getReadability($data, 'http://iosgames.ru/?p=22030');
         $readability->debug = true;
 
         $res = $readability->init();
@@ -379,4 +374,85 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase
         $this->assertContains('<iframe src="https://www.youtube.com/embed/PUep6xNeKjA" width="560" height="315" frameborder="0" allowfullscreen="allowfullscreen"> </iframe>', $readability->getContent()->innerHTML);
         $this->assertContains('3D Touch', $readability->getTitle()->innerHTML);
     }
+
+    /**
+     * This should generate an Exception "DOMElement::setAttribute(): ID post-60 already defined"
+     */
+    public function testAppendIdAlreadyHere()
+    {
+        $data = '<!DOCTYPE html>
+            <html lang="fr">
+            <head>
+                <meta charset="utf-8">
+                <meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1.0">
+            </head>
+            <body>
+                <div class="container">
+                    <header class="header sml-text-center med-text-left" role="banner">
+                        <h1 class="no-margin"><a class="maintitle" href="https://0.0.0.0" title="Bloc-notes">Bloc-notes</a></h1>
+                        <h2 class="h5 no-margin"></h2>
+                    </header>
+
+                    <nav class="nav" role="navigation">
+                        <div class="responsive-menu">
+                            <label for="menu">Menu</label>
+                            <input type="checkbox" id="menu">
+                        </div>
+                    </nav>
+
+                    <article class="article" role="article" id="post-60">
+                        <section>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are<br/>
+                            This is an awesome text with some links, here there are
+                        </section>
+                        <footer>
+                            <small>
+                                Classé dans : <a class="noactive" title="Services réseaux">Services réseaux</a>
+                            </small>
+                        </footer>
+                    </article>
+                </div>
+            </body>
+            </html>';
+
+        $readability = $this->getReadability($data, 'http://0.0.0.0');
+        $readability->debug = true;
+
+        $res = $readability->init();
+
+        $this->assertTrue($res);
+        $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getContent());
+        $this->assertInstanceOf('Readability\JSLikeHTMLElement', $readability->getTitle());
+    }
+
+    public function testPostFilters()
+    {
+        $readability = $this->getReadability('<div>'.str_repeat('<p>This <b>is</b> the awesome content :)</p>', 7).'</div>', 'http://0.0.0.0');
+        $readability->addPostFilter('!<strong[^>]*>(.*?)</strong>!is', '');
+
+        $res = $readability->init();
+
+        $this->assertTrue($res);
+        $this->assertContains('This  the awesome content :)', $readability->getContent()->innerHTML);
+    }
+
+    public function testPreFilters()
+    {
+        $readability = $this->getReadability('<div>'.str_repeat('<p>This <b>is</b> the awesome and WONDERFUL content :)</p>', 7).'</div>', 'http://0.0.0.0');
+        $readability->addPreFilter('!<b[^>]*>(.*?)</b>!is', '');
+
+        $res = $readability->init();
+
+        $this->assertTrue($res);
+        $this->assertContains('This the awesome and WONDERFUL content :)', $readability->getContent()->innerHTML);
+    }
 }