Since we require PHP 7.4, contravariance in param types is supported, so we do not need to worry about subclasses that widen the param type. It will be only breaking in the unlikely case a subclass uses a type that contradicts the PHPDoc type annotation and does not not extend `DOMNode`. Also fix the type annotation since some invocations pass it a `DOMText`, an arbitrary sibling/child `DOMNode` or even `null`.pull/93/head
parent
9a0a088bc6
commit
5040fc1587
2 changed files with 2 additions and 5 deletions
Loading…
Reference in new issue