tests: Fix “THE ERROR HANDLER HAS CHANGED!”

3 years ago · 23f824a1ce
parent 2a57124528
commit 23f824a1ce
1 changed files with 43 additions and 35 deletions
--- a/tests/ReadabilityTest.php
+++ b/tests/ReadabilityTest.php
@ -335,13 +335,14 @@ class ReadabilityTest extends \PHPUnit\Framework\TestCase

    public function testAutoClosingIframeNotThrowingException(): void
    {
-        error_reporting(\E_ALL | \E_STRICT);
-        ini_set('display_errors', '1');
+        $oldErrorReporting = error_reporting(\E_ALL | \E_STRICT);
+        $oldDisplayErrors = ini_set('display_errors', '1');
        // dummy function to be used to the next test
        set_error_handler(function (int $errno, string $errstr, string $errfile, int $errline, array $errcontext) {
            throw new \Exception($errstr, $errno);
        }, \E_ALL | \E_STRICT);

+        try {
            $data = '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
                <html xmlns="http://www.w3.org/1999/xhtml" lang="ru-RU" prefix="og: http://ogp.me/ns#">

@ -377,6 +378,13 @@ class ReadabilityTest extends \PHPUnit\Framework\TestCase
            $this->assertInstanceOf(JSLikeHTMLElement::class, $readability->getTitle());
            $this->assertStringContainsString('<iframe src="https://www.youtube.com/embed/PUep6xNeKjA" width="560" height="315" frameborder="0" allowfullscreen="allowfullscreen"> </iframe>', $readability->getContent()->getInnerHtml());
            $this->assertStringContainsString('3D Touch', $readability->getTitle()->getInnerHtml());
+        } finally {
+            restore_error_handler();
+            if (false !== $oldDisplayErrors) {
+                ini_set('display_errors', $oldDisplayErrors);
+            }
+            error_reporting($oldErrorReporting);
+        }
    }

    /**