Merge pull request #30 from j0k3r/avoid-php-warning

Avoid php warning
Fix tests
2026-09-27 14:36:23 +00:00 · 2017-05-19 16:16:20 +02:00 · 2017-05-19 16:02:36 +02:00 · 2017-05-19 15:37:46 +02:00
2 changed files with 51 additions and 44 deletions
@@ -45,19 +45,31 @@ class JSLikeHTMLElement extends \DOMElement
     */
    public function __set($name, $value)
    {
-        if ($name === 'innerHTML') {
+        if ($name !== 'innerHTML') {
+            $trace = debug_backtrace();
+            trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_NOTICE);
+
+            return;
+        }
+
        // first, empty the element
        for ($x = $this->childNodes->length - 1; $x >= 0; --$x) {
            $this->removeChild($this->childNodes->item($x));
        }

        // $value holds our new inner HTML
-            if ($value !== '') {
+        $value = trim($value);
+        if (empty($value)) {
+            return;
+        }
+
+        // ensure bad entity won't generate warning
+        $previousError = libxml_use_internal_errors(true);
+
        $f = $this->ownerDocument->createDocumentFragment();

        // appendXML() expects well-formed markup (XHTML)
-                // @ to suppress PHP warnings
-                $result = @$f->appendXML($value);
+        $result = $f->appendXML($value);
        if ($result) {
            if ($f->hasChildNodes()) {
                $this->appendChild($f);
@@ -72,7 +84,7 @@ class JSLikeHTMLElement extends \DOMElement
            // We use it (and suppress the warning) because an HTML fragment will
            // be wrapped around <html><body> tags which we don't really want to keep.
            // Note: despite the warning, if loadHTML succeeds it will return true.
-                    $result = @$f->loadHTML('<htmlfragment>' . $value . '</htmlfragment>');
+            $result = $f->loadHTML('<htmlfragment>' . $value . '</htmlfragment>');

            if ($result) {
                $import = $f->getElementsByTagName('htmlfragment')->item(0);
@@ -81,16 +93,11 @@ class JSLikeHTMLElement extends \DOMElement
                    $importedNode = $this->ownerDocument->importNode($child, true);
                    $this->appendChild($importedNode);
                }
-                    } else {
-                        // oh well, we tried, we really did. :(
-                        // this element is now empty
            }
        }
-            }
-        } else {
-            $trace = debug_backtrace();
-            trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_NOTICE);
-        }
+
+        libxml_clear_errors();
+        libxml_use_internal_errors($previousError);
    }

    /**
@@ -443,7 +443,7 @@ class ReadabilityTest extends \PHPUnit_Framework_TestCase

    public function testPostFilters()
    {
-        $readability = $this->getReadability('<div>' . str_repeat('<p>This <b>is</b> the awesome content :)</p>', 7) . '</div>', 'http://0.0.0.0');
+        $readability = $this->getReadability('<div>' . str_repeat('<p>This <b>is</b> the awesome content :)</p>', 10) . '</div>', 'http://0.0.0.0');
        $readability->addPostFilter('!<strong[^>]*>(.*?)</strong>!is', '');

        $res = $readability->init();
Author	SHA1	Message	Date
Jérémy BenoistandGitHub	5ac82f3c87	Merge pull request #30 from j0k3r/avoid-php-warning Avoid php warning	2017-05-19 16:16:20 +02:00
Jeremy Benoist	85fb92a042	Fix tests	2017-05-19 16:02:36 +02:00
Jeremy Benoist	f2a43b476c	Avoid PHP Warning This isn't the best solution but the previous one using `@` wasn't really better. Appending a string into a fragment might generate some warning if the string contains bad entity. For example `+`.	2017-05-19 15:37:46 +02:00