From c756ec067ebde8964edc8f15eb5a195ea0827d68 Mon Sep 17 00:00:00 2001 From: Jeremy Benoist Date: Mon, 29 Feb 2016 13:09:16 +0100 Subject: [PATCH] Fix tests `getInnerText` might receive a null DOMElement if the xpath or query return no element. --- src/Readability.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Readability.php b/src/Readability.php index cb42741..2969c4b 100644 --- a/src/Readability.php +++ b/src/Readability.php @@ -235,8 +235,6 @@ class Readability implements LoggerAwareInterface * Load HTML in a DOMDocument. * Apply Pre filters * Cleanup HTML using Tidy (or not). - * - * @return [type] [description] */ private function loadHtml() { @@ -1053,9 +1051,9 @@ class Readability implements LoggerAwareInterface * * @return string */ - public function getInnerText(\DOMElement $e, $normalizeSpaces = true, $flattenLines = false) + public function getInnerText(\DOMElement $e = null, $normalizeSpaces = true, $flattenLines = false) { - if (!isset($e->textContent) || $e->textContent === '') { + if (null === $e || !isset($e->textContent) || $e->textContent === '') { return ''; }