infong/php-readability
1
0
Fork 0
mirror of https://github.com/j0k3r/php-readability.git synced 2026-09-27 06:26:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract for-iterated items into variables

Browse Source 
This simplifies the code a bit and will make it slightly easier in case we decide to switch to `foreach` iteration.
This commit is contained in:
Jan Tojnar
2024-10-10 09:01:45 +02:00
parent 5885dbbe78
commit 8b1ef07401
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Readability.php
+8 -5
View File
@@ -586,7 +586,7 @@ class Readability implements LoggerAwareInterface
} }
// Then check the elements inside this element for the same. // Then check the elements inside this element for the same.
if (preg_match($this->regexps['media'], $targetList->item($y)->getInnerHTML())) { if (preg_match($this->regexps['media'], $currentItem->getInnerHTML())) {
continue; continue;
} }
} }
@@ -719,8 +719,9 @@ class Readability implements LoggerAwareInterface
$headers = $e->getElementsByTagName('h' . $headerIndex); $headers = $e->getElementsByTagName('h' . $headerIndex);
for ($i = $headers->length - 1; $i >= 0; --$i) { for ($i = $headers->length - 1; $i >= 0; --$i) {
if ($this->getWeight($headers->item($i)) < 0 || $this->getLinkDensity($headers->item($i)) > 0.33) { $header = $headers->item($i);
$headers->item($i)->parentNode->removeChild($headers->item($i)); if ($this->getWeight($header) < 0 || $this->getLinkDensity($header) > 0.33) {
$header->parentNode->removeChild($header);
} }
} }
} }
@@ -812,12 +813,14 @@ class Readability implements LoggerAwareInterface
// Remove all style tags in head. // Remove all style tags in head.
$styleTags = $this->dom->getElementsByTagName('style'); $styleTags = $this->dom->getElementsByTagName('style');
for ($i = $styleTags->length - 1; $i >= 0; --$i) { for ($i = $styleTags->length - 1; $i >= 0; --$i) {
$styleTags->item($i)->parentNode->removeChild($styleTags->item($i)); $styleTag = $styleTags->item($i);
$styleTag->parentNode->removeChild($styleTag);
} }
$linkTags = $this->dom->getElementsByTagName('link'); $linkTags = $this->dom->getElementsByTagName('link');
for ($i = $linkTags->length - 1; $i >= 0; --$i) { for ($i = $linkTags->length - 1; $i >= 0; --$i) {
$linkTags->item($i)->parentNode->removeChild($linkTags->item($i)); $linkTag = $linkTags->item($i);
$linkTag->parentNode->removeChild($linkTag);
} }
} }