From 76908b19bab81dbe6aa9fadc33abb45fdf444f16 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sun, 17 Mar 2024 03:17:21 +0100 Subject: [PATCH] Extract `for`-iterated items into variables This simplifies the code a bit and will make it slightly easier in case we decide to switch to `foreach` iteration. --- src/Readability.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Readability.php b/src/Readability.php index ff628cd..6996e50 100644 --- a/src/Readability.php +++ b/src/Readability.php @@ -719,8 +719,9 @@ class Readability implements LoggerAwareInterface $headers = $e->getElementsByTagName('h' . $headerIndex); for ($i = $headers->length - 1; $i >= 0; --$i) { - if ($this->getWeight($headers->item($i)) < 0 || $this->getLinkDensity($headers->item($i)) > 0.33) { - $headers->item($i)->parentNode->removeChild($headers->item($i)); + $header = $headers->item($i); + if ($this->getWeight($header) < 0 || $this->getLinkDensity($header) > 0.33) { + $header->parentNode->removeChild($header); } } } @@ -812,12 +813,14 @@ class Readability implements LoggerAwareInterface // Remove all style tags in head. $styleTags = $this->dom->getElementsByTagName('style'); for ($i = $styleTags->length - 1; $i >= 0; --$i) { - $styleTags->item($i)->parentNode->removeChild($styleTags->item($i)); + $styleTag = $styleTags->item($i); + $styleTag->parentNode->removeChild($styleTag); } $linkTags = $this->dom->getElementsByTagName('link'); for ($i = $linkTags->length - 1; $i >= 0; --$i) { - $linkTags->item($i)->parentNode->removeChild($linkTags->item($i)); + $linkTag = $linkTags->item($i); + $linkTag->parentNode->removeChild($linkTag); } }